Skip to content

fix: re-export CDP Session directly from playwright - #8702

Merged
sheremet-va merged 2 commits into
vitest-dev:mainfrom
mrginglymus:pw-fix4
Oct 13, 2025
Merged

sheremet-va merged 2 commits into
vitest-dev:mainfrom
mrginglymus:pw-fix4

Conversation

@mrginglymus

@mrginglymus mrginglymus commented Oct 13, 2025 •

Copy link
Copy Markdown
Contributor

Description

Fix removal of the playwright-core/types/protocol export.

Should fix #8671 for v4

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify

netlify Bot commented Oct 13, 2025

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1763a74
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68eca84c566b9e0008a95506
😎 Deploy Preview https://deploy-preview-8702--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mrginglymus

Copy link
Copy Markdown
Contributor Author

urgh, that's an annoying bug in rollup-plugin-dts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playwright 1.56.0 removes Protocol export from playwright-core

2 participants