Skip to content

fix: custom expect messages for expect.extend matchers - #8520

Merged
sheremet-va merged 1 commit into
vitest-dev:mainfrom
lzl0304:fix-8366
Sep 5, 2025
Merged

sheremet-va merged 1 commit into
vitest-dev:mainfrom
lzl0304:fix-8366

Conversation

@lzl0304

@lzl0304 lzl0304 commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Description

When passing a message parameter to expect(), the custom message was not
included in the final error for matchers defined using expect.extend().

fixes #8366

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify

netlify Bot commented Sep 1, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b933572
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68b8391157cb27000883f782
😎 Deploy Preview https://deploy-preview-8520--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread packages/expect/src/jest-extend.ts Outdated
Comment thread packages/expect/src/jest-extend.ts Outdated
@lzl0304
lzl0304 force-pushed the fix-8366 branch 2 times, most recently from b933572 to eb5f1aa Compare September 3, 2025 12:53
Comment thread packages/expect/src/jest-extend.ts Outdated
Comment thread test/core/test/expect.test.ts Outdated
Comment thread test/core/test/expect.test.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Expect messages are not displayed for custom matchers

2 participants