Repository navigation
perf: remove chai as a direct dependency, keep it in @vitest/expect - #8461
Merged
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
reviewed
Aug 22, 2025
| "devDependencies": { | ||
| "@vitest/runner": "workspace:*", | ||
| "rollup-plugin-copy": "^3.5.0" | ||
| "chai": "catalog:" |
Member
There was a problem hiding this comment.
Latest ^5 and 6 versions should be good now, no need for bundling.
const startTime = performance.now();
await import("chai");
// "chai": "5.2.1" > 4.39 ms
// "chai": "5.3.1" > 13.52 ms
// "chai": "5.3.2" > 2.92 ms
// "chai": "6.0.0" > 2.87 ms
console.log(`${(performance.now() - startTime).toFixed(2)} ms`);
Member
Author
There was a problem hiding this comment.
Sounds good. Let's keep chai in dependencies.
sheremet-va
changed the title
@vitest/expect
1 task
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were also installing chai in both
@vitest/expectandvitest. This duplicated the amount of work Node.js needs to do. Removingchaifromvitest(but keeping it inexpect) removes ~10ms at startup for every test file.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.