Skip to content

feat(api): add enableCoverage and disableCoverage methods - #8412

Merged
sheremet-va merged 10 commits into
vitest-dev:mainfrom
sheremet-va:feat/expose-dynamic-coverage-enable
Aug 12, 2025
Merged

feat(api): add enableCoverage and disableCoverage methods#8412
sheremet-va merged 10 commits into
vitest-dev:mainfrom
sheremet-va:feat/expose-dynamic-coverage-enable

Conversation

@sheremet-va

@sheremet-va sheremet-va commented Aug 8, 2025

Copy link
Copy Markdown
Member

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify

netlify Bot commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit b06dd06
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6895f392733001000830bebb
😎 Deploy Preview https://deploy-preview-8412--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va
sheremet-va requested a review from AriPerkkio August 8, 2025 11:24
@sheremet-va
sheremet-va marked this pull request as ready for review August 8, 2025 11:24
AriPerkkio
AriPerkkio reviewed Aug 8, 2025
View reviewed changes
Comment thread test/coverage-test/test/run-dynamic-coverage.test.ts Outdated
Comment thread test/coverage-test/test/run-dynamic-coverage.test.ts Outdated
Comment thread test/coverage-test/test/run-dynamic-coverage.test.ts Outdated
Comment thread packages/vitest/src/node/core.ts Outdated
@sheremet-va
sheremet-va requested a review from AriPerkkio August 8, 2025 13:58
AriPerkkio
AriPerkkio previously approved these changes Aug 9, 2025
View reviewed changes

@AriPerkkio AriPerkkio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I guess this is for VSCode extension?

Comment thread packages/coverage-istanbul/src/provider.ts Outdated
@sheremet-va

sheremet-va commented Aug 12, 2025

Copy link
Copy Markdown
Member Author

Looks good! I guess this is for VSCode extension?

Yes, it was already using it for a while, but with hacks (overriding coverageProvider into a getter)

@sheremet-va
sheremet-va merged commit 61eb7dd into vitest-dev:main Aug 12, 2025
@sheremet-va
sheremet-va deleted the feat/expose-dynamic-coverage-enable branch August 12, 2025 12:50
This was referenced Nov 3, 2025
Closed
Closed
@CataldoMazzilli CataldoMazzilli mentioned this pull request Jun 5, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Sep 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AriPerkkio AriPerkkio AriPerkkio left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sheremet-va @AriPerkkio