Skip to content

feat: add qwik to the cli - #8330

Merged
sheremet-va merged 2 commits into
vitest-dev:mainfrom
thejackshelton:feat/cli-add-qwik
Jul 22, 2025
Merged

feat: add qwik to the cli#8330
sheremet-va merged 2 commits into
vitest-dev:mainfrom
thejackshelton:feat/cli-add-qwik

Conversation

@thejackshelton

@thejackshelton thejackshelton commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify

netlify Bot commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ae1f3aa
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/687e8373935f3100083980a2
😎 Deploy Preview https://deploy-preview-8330--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va

sheremet-va commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

By the way, you can also add an example here: https://github.com/vitest-tests/browser-examples

This is where we actually run them. They should probably be generated automatically though 😄

@thejackshelton
thejackshelton marked this pull request as draft July 21, 2025 16:02
@thejackshelton

thejackshelton commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sheremet-va which command automatically creates the example? I see the all the tests scripts locally, and they pass, including the test file mentioned earlier.

Also not sure why the rolldown test is failing specifically in ci 🤔 . I notice the same action failing in other PR's, maybe we need to re-run the action?

@thejackshelton
thejackshelton marked this pull request as ready for review July 21, 2025 18:37
@sheremet-va

sheremet-va commented Jul 22, 2025

Copy link
Copy Markdown
Member

@sheremet-va which command automatically creates the example? I see the all the tests scripts locally, and they pass, including the test file mentioned earlier.

There is no command that does this automatically. I didn't propose you do it automatically, I noticed that we should generate them automatically 😄

@sheremet-va
sheremet-va merged commit 1638b44 into vitest-dev:main Jul 22, 2025
This was referenced Nov 3, 2025
Closed
Closed
@CataldoMazzilli CataldoMazzilli mentioned this pull request Jun 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thejackshelton @sheremet-va