Repository navigation
fix: add --changed flag support to vitest list command (fix #8270) - #8272
Merged
sheremet-va merged 2 commits intoJul 22, 2025
Merged
Conversation
haakonjackfloat
marked this pull request as ready for review
July 7, 2025 17:39
sheremet-va
approved these changes
Jul 14, 2025
sheremet-va
requested changes
Jul 14, 2025
| @@ -888,7 +888,7 @@ export const benchCliOptionsConfig: Pick< | |||
|
|
|||
| export const collectCliOptionsConfig: Pick< | |||
Member
There was a problem hiding this comment.
I think the expected behaviour is that this config extends the original one, not overrides it. It seems like a bug that it doesn't support all other options
Contributor
Author
There was a problem hiding this comment.
Ah, good to know! I'll update accordingly :)
Contributor
Author
There was a problem hiding this comment.
@sheremet-va I've updated collectCliOptionsConfig to inherit everything from cliOptionsConfig. I also tweaked the description for changed to be more consistent with the json and filesOnly options (e.g. changing Run tests to Print tests)
Addressing PR feedback
sheremet-va
approved these changes
Jul 22, 2025
1 of 7 tasks
This was referenced Nov 3, 2025
This was referenced Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
vitest list --changedcommand was ignoring the--changedflag and showing all tests instead of only those affected by changed files. This was inconsistent with the behavior of the regularvitest --changedcommand, which correctly filters tests based on git changes.What this PR solves:
--changedflag now works correctly with thevitest listcommandvitest list --changedPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
--changedflag is ignored when runningvitest list --changed#8270 where the bug was reported and discussedtest/cli/test/list-changed.test.tswith 5 test cases that verify the fix works correctlypnpm-lock.yamlunless you introduce a new test example.pnpm-lock.yaml- only added test files and modified existing codeTests
pnpm test:ci.Documentation
pnpm run docscommand.--changedflag was already documented in the CLI docs, it just wasn't working with thelistcommandChangesets
feat:,fix:,perf:,docs:, orchore:.fix: add --changed flag support to vitest list command (fix #8270)fix: add --changed flag support to vitest list command