Repository navigation
feat: provide entity to onConsoleLog - #8159
Merged
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
reviewed
Jun 13, 2025
AriPerkkio
left a comment
AriPerkkio
left a comment
Member
There was a problem hiding this comment.
Looks good! Let's also update docs.
Comment on lines
+436
to
+438
| const task = log.taskId ? this.ctx.state.idMap.get(log.taskId) : undefined | ||
| const entity = task && this.ctx.state.getReportedEntity(task) | ||
| const shouldLog = this.ctx.config.onConsoleLog?.(log.content, log.type, entity) |
Member
There was a problem hiding this comment.
Nitpick, but could avoid getReportedEntity and idMap.get calls:
let shouldLog = true;
if(this.ctx.config.onConsoleLog) {
const task = log.taskId ? this.ctx.state.idMap.get(log.taskId) : undefined
const entity = task && this.ctx.state.getReportedEntity(task)
shouldLog = this.ctx.config.onConsoleLog(log.content, log.type, entity)
}
Member
Author
There was a problem hiding this comment.
We need to decide in what version we will release this. Technically this is a feature, but I am not planning to have 3.3 (or I guess we can have a mini release?)
AriPerkkio
approved these changes
Jun 14, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8156
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.