Allow configureable WebPDF JavaScript processing timeout - #2250
Merged
Merged
Conversation
Carreau
force-pushed
the
tkp/webpdftimeout
branch
from
February 25, 2026 13:06
0d603a5 to
0eca34f
Compare
Member
|
Only pre-seleases seem to fail and not related to us, so i think this is good. |
Carreau
approved these changes
Feb 25, 2026
codechrl
added a commit
to codechrl/nbconvert
that referenced
this pull request
Aug 12, 2026
pre-commit.ci runs with --all-files, so both of these currently fail on every open pull request, not just the one that touches them: - codespell: "configureable" -> "configurable" (CHANGELOG.md:18). That entry is generated from the title of jupyter#2250, so the typo can only be corrected here. - blacken-docs: a Python block in the 5.6.1 section was missing the blank line black requires before a top-level statement. Verified against the pinned hook versions: codespell 2.4.2 with -L sur,nd,assertin, blacken-docs 1.20.0 with black 23.7.0, and mdformat 1.0.0. All three are clean afterwards and mdformat leaves the file unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2244
Note that i don't think we can do something like "wait for all activity to cease" as some stuff may never cease, so putting it in the user's hands make sense.