Repository navigation
feat(valid-expect-with-promise): add checkThenables option for custom promises - #1996
Merged
G-Rath merged 2 commits intoJul 24, 2026
Conversation
G-Rath
requested changes
Jul 22, 2026
G-Rath
left a comment
G-Rath
left a comment
Collaborator
There was a problem hiding this comment.
I think this should be an option like with no-floating-promises (which is the rule I used as a reference when implementing this), since not everything with a then is a promise.
For example, Cypress has a then function which is not a promise
Collaborator
|
I would also suggest checking out their implementation, as I assume it's a good default in terms of what to check for |
christopher-buss
force-pushed
the
fix/valid-expect-with-promise-thenables
branch
from
July 22, 2026 11:46
3d22fbd to
2f540df
Compare
Contributor
Author
|
don't think the errors here are related to me from what I can tell |
G-Rath
changed the title
checkThenables option for custom promises
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
# [29.16.0](v29.15.5...v29.16.0) (2026-07-24) ### Features * **valid-expect-with-promise:** add `checkThenables` option for custom promises ([#1996](#1996)) ([692c748](692c748))
|
🎉 This PR is included in version 29.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using a
Promisenot from the default lib therefore the rule does not fire. This PR removes the requirement for a Promise to be from the default library and instead falls back to checking if it's any thenable type.