Skip to content

fix(coverage): v8 to ignore Vite's generated cjs import helpers #8718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AriPerkkio merged 4 commits into from
Oct 16, 2025
Merged

fix(coverage): v8 to ignore Vite's generated cjs import helpers #8718

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a808ae
Add ignore path for cjs imports in v8 branch coverage
mrginglymus Oct 14, 2025
9c0b789
test: cjs transform ignores test
AriPerkkio Oct 15, 2025
f6e6c1a
test: add `@vitest/cjs-lib` to `optimizeDeps`
AriPerkkio Oct 15, 2025
305d9ab
test: unique `cacheDir` to avoid `optimizeDeps` conflicts
AriPerkkio Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/coverage-v8/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,20 @@ export class V8CoverageProvider extends BaseCoverageProvider<ResolvedCoverageOpt
return true
}

// CJS imports as ternaries - e.g.
// const React = __vite__cjsImport0_react.__esModule ? __vite__cjsImport0_react.default : __vite__cjsImport0_react;
if (
type === 'branch'
&& node.type === 'ConditionalExpression'
&& node.test.type === 'MemberExpression'
&& node.test.object.type === 'Identifier'
&& node.test.object.name.startsWith('__vite__cjsImport')
&& node.test.property.type === 'Identifier'
&& node.test.property.name === '__esModule'
) {
return true
}

// in-source test with "if (import.meta.vitest)"
if (
(type === 'branch' || type === 'statement')
Expand Down
Loading