Repository navigation
Conversation
…hout configuration files to avoid duplicate testing
Enhanced project resolution logic to exclude subdirectories that are already configured as independent projects, preventing duplicate test execution in overlapping workspace glob patterns.
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I don't like this. The |
|
Thank you for your feedback! I understand your consideration of keeping the project glob simple. Regarding the Complexity of Manual ExclusionYou mentioned using the negative glob This syntax is not intuitive for many developers, especially in large monorepos where multiple such exclusion rules may need to be maintained, which imposes a certain mental burden. The Significance of the Current SolutionThis modification mainly addresses the issue where developers' expectations do not match the actual behavior:
Improvement SuggestionsI fully understand your concern about maintaining simplicity. Could we consider making this feature an optional one? For example: This way, the simplicity of the existing behavior is preserved, while providing an option for users who need such intelligent handling. What do you think of this optional approach? Looking forward to your feedback. |
|
@sheremet-va What about inline configurations ? Let's say the root config is In CI, you may want to run e2e tests using the docker image provided playwright along with Currently, projects do not run nested projects, inline or not. |
Then perhaps adding the example to the documentation is enough. Magically removing files from the glob you specified is more confusing than the current behaviour where we process everything that your glob matches.
This PR has nothing to do with inline configuration. |
|
That’s true, you’ve got a point. |
Description
Fix the repeated execution of test cases when Test Projects have multi-level nesting, and eliminate unexpected and undesired duplicate content;
For example, regarding the added test cases, I expect the content under business/ to execute the test cases using its own directory configuration, just like the directories under packages/. Therefore, I added packages/business/*.


However, this currently results in duplicate execution directories: packages/business and packages/business/pkg, and the execution of packages/business is not as expected.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.