Repository navigation
fix(docker): preserve valid seeds in crawl batches - #2347
Open
nightcityblade wants to merge 1 commit into
Open
nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2288.
Mixed
/crawlbatches now keep destination validation per seed: blocked or unresolvable seeds become opaque failed results, while valid seeds are still crawled. Results and per-URL crawler configs retain their original input order. Single-URL requests keep the existing HTTP 400 behavior.List of files changed and why
deploy/docker/api.py- Partition multi-URL batches into valid seeds and per-seed validation failures, crawl the valid subset, and merge results in request order.tests/test_docker_pdf_crawler_pairing.py- Add regression coverage for one blocked seed alongside one valid seed.How Has This Been Tested?
uv sync --python 3.12 --frozen --devuv pip install --python .venv/bin/python -r deploy/docker/requirements.txt -r deploy/docker/tests/requirements.txt pytest pytest-asyncio black ruff.venv/bin/python -m pytest deploy/docker/tests/test_security_ssrf_crawl.py tests/test_docker_pdf_crawler_pairing.py -q— 37 passed.venv/bin/ruff check --select E9,F63,F7,F82 deploy/docker/api.py tests/test_docker_pdf_crawler_pairing.py— passed.venv/bin/python -m compileall -q deploy/docker/api.py tests/test_docker_pdf_crawler_pairing.py— passedarun_many, and both ordered results were returnedgit diff --check upstream/develop...HEAD— passedChecklist: