Repository navigation
feat: add withSymlinks argument back - #104
Merged
Merged
Conversation
SuperchupuDev
force-pushed
the
feat/use-real-paths
branch
from
July 30, 2024 11:09
c5e3e4d to
75951c8
Compare
SuperchupuDev
force-pushed
the
feat/use-real-paths
branch
from
July 30, 2024 11:30
75951c8 to
3dfa66b
Compare
This was referenced Jul 30, 2024
Contributor
Author
|
hi @thecodrr, any chance you can take a look at this anytime soon? symlinks wont quite work in my library until this (or an equivalent solution) is merged |
Owner
|
Relevant commit: cdb201f |
Contributor
Author
|
yes, that commit is what this PR aims to implement, but #81 removed the |
SuperchupuDev
changed the title
useRealPaths backwithSymlinks argument back
thecodrr
requested changes
Aug 5, 2024
thecodrr
left a comment
thecodrr
left a comment
Owner
There was a problem hiding this comment.
Thank you so much for adding this back!
Co-authored-by: Abdullah Atta <[email protected]>
Contributor
Author
|
changing it to lstat makes this test fail as it makes it return non-resolved symlinks |
This reverts commit e6ebb44.
Contributor
Author
|
@thecodrr i've reverted the |
Contributor
Author
|
@thecodrr is there anything blocking the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on
tinyglobbyI've noticed there is no way to disablefdirreturning the real path of a symlink anymore, due to #81 silently removing support for it (even though the documentation still mentions the feature!).This PR adds it back, inside an object parameter instead for better API design (see #83 (comment)). It defaults to
truefor backwards compatibilityCloses #103