[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jkhelil after the PR has been reviewed.
You can assign the PR to them by writing /assign @jkhelil in a comment when ready.

The full list of commands accepted by this bot can be found here.

The committers listed above are authorized under a signed CLA.

• ✅ login: shashankxrm / name: Shashank RM (40084c1)

@shashankxrm Thanks for the PR. please confirm human ownership of the change:

1. In your own words: what breaks without STATEFUL_REPLICA_COUNT, and why syncing after additional options is required? (concrete CR example)
2. Paste local test output for:
   • go test ./pkg/reconciler/common/ -run TestAddStatefulEnvVars -count=1
   • go test ./pkg/reconciler/kubernetes/tektonpipeline/ -run TestValidateStatefulSetOrdinalsAfterOptions -count=1
3. Confirm whether this is needed now because knative/pkg already requires the env in our go.mod, or is preparatory for a future bump (link the validating code).
4. Optional but preferred: show rendered StatefulSet env before/after an options replica override (4 → 8) with matching buckets.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.72%. Comparing base (a951115) to head (40084c1).
⚠️ Report is 30 commits behind head on main.

@@            Coverage Diff             @@
##             main    #4124      +/-   ##
==========================================
+ Coverage   27.66%   27.72%   +0.05%     
==========================================
  Files         477      477              
  Lines       25469    25518      +49     
==========================================
+ Hits         7046     7074      +28     
- Misses      17699    17714      +15     
- Partials      724      730       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

STATEFUL_REPLICA_COUNT is not used in knative/pkg.
knative/pkg#3393 is still open. Buckets==replicas is already enforced by the operator.

/hold

@shashankxrm Thanks for the PR. please confirm human ownership of the change:

1. In your own words: what breaks without STATEFUL_REPLICA_COUNT, and why syncing after additional options is required? (concrete CR example)

2. Paste local test output for:

   • go test ./pkg/reconciler/common/ -run TestAddStatefulEnvVars -count=1
   • go test ./pkg/reconciler/kubernetes/tektonpipeline/ -run TestValidateStatefulSetOrdinalsAfterOptions -count=1

3. Confirm whether this is needed now because knative/pkg already requires the env in our go.mod, or is preparatory for a future bump (link the validating code).

4. Optional but preferred: show rendered StatefulSet env before/after an options replica override (4 → 8) with matching buckets.

You're right that the current knative.dev/pkg version doesn't use STATEFUL_REPLICA_COUNT yet. The operator already validates that buckets and replicas match, so this is mainly in preparation for #3393.

The reason I added the sync after additional options is because the env is set before those options are applied. For example, if the initial values are replicas: 4 and buckets: 4, the env gets set to 4. If an additional option changes the rendered StatefulSet replicas and buckets to 8, the env would still be 4. With #3393, that would fail the new replica-count check even though the final rendered StatefulSet and ConfigMap both have 8.

The two requested tests pass:

$ go test ./pkg/reconciler/common/ -run TestAddStatefulEnvVars -count=1
ok  	github.com/tektoncd/operator/pkg/reconciler/common	1.436s

$ go test ./pkg/reconciler/kubernetes/tektonpipeline/ -run TestValidateStatefulSetOrdinalsAfterOptions -count=1
ok  	github.com/tektoncd/operator/pkg/reconciler/kubernetes/tektonpipeline	1.039s

The current buckets == replicas validation is in pkg/apis/operator/v1alpha1/performance_validation.go, and the rendered Pipeline validation after options is in pkg/reconciler/kubernetes/tektonpipeline/transform.go.

I didn't add separate before/after output since the requested tests don't print the rendered StatefulSet, but the test does verify the final replica count and env value.