Repository navigation
Fix/tab roving tabindex - #1
Merged
soroush5 merged 6 commits intoSep 22, 2026
Merged
Conversation
Bump CFPB DS, React, and Storybook while leaving TypeScript 6, Vitest 4, and Unicorn 73 so the existing ESLint and Storybook toolchain still resolve. Slaying the tech debt monster and trying to stay afloat To test, go to the preview link and things should still work normally.
Fixes the tagline init in storybook. I broke the tagline in this eslint PR https://github.com/cfpb/design-system-react/pull/625/changes#diff-d55d3d2db0049223a16bdfda90d1a4fa1adceae59cf7f29ec0ac75f4f8877f4aL5 `cfpb-tagline` only upgrades after CfpbTagline.init() registers it. The Taglines stories had a wrapper that called init(), but Standard and Large overrode render with a raw `<cfpb-tagline>` and never ran that wrapper. Storybook therefore painted the undefined-element placeholder and left it there. to verify go to the storybook preview link for tagline: https://cfpb.github.io/design-system-react/pr-previews/pr-640/?path=/docs/components-verified-taglines--overview
Should merge #644 first
updating version number to release latest DSR
soroush5
approved these changes
Sep 22, 2026
soroush5
left a comment
soroush5
left a comment
Owner
There was a problem hiding this comment.
Looks good, thanks. Merging this into the branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just fixed a bunch of lint warnings when you run
yarn startand updated the branch