#3784 Document Unused Tokens - #3836
Weltraumschaf wants to merge 1 commit into
Conversation
So we have the names somewhere before deleting it. Just in case we need to restore them. Signed-off-by: Sven Strittmatter <[email protected]>
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
| - `HELM_REGISTRY_PASSWORD`: 🤷♂️ Not found in any repo nor password manager. | ||
| - `HELM_REGISTRY_USERNAME`: 🤷♂️ Not found in any repo nor password manager. |
There was a problem hiding this comment.
i've intentionally removed the HELM_REGISTRY_ ones from the list as they are no longer used.
I've now also deleted the secrets
| - `GPG_COMMITS_PRIVATE_KEY`: GPG private key for the secureCodeBoxBot used to sign Maven releases. | ||
| - `HELM_REGISTRY_PASSWORD`: 🤷♂️ Not found in any repo nor password manager. | ||
| - `HELM_REGISTRY_USERNAME`: 🤷♂️ Not found in any repo nor password manager. | ||
| - `PAT_WITH_ADMIN`: 🤷♂️ Not found in any repo nor password manager. |
There was a problem hiding this comment.
Please just delete the token, we will never find out otherwise if its used
| - **`SONAR_TOKEN`** — Token for SonarCloud. | ||
| - `CC_TEST_REPORTER_ID`: 🤷♂️ Not found in any repo nor password manager. | ||
| - `DOCKER_NAMESPACE`: Namespace for the DockerHub images. For the main repository this is *securecodebox*. | ||
| - `DOCKER_PASSWORD`: 🤷♂️ Not found in any repo nor password manager. |
There was a problem hiding this comment.
Was probably used before we switched to DOCKER_TOKEN, pls just delete
| - **`SCB_BOT_DOCU_ROULETTE_TOKEN`** — GitHub token for the documentation roulette (needs `org:read` permission). | ||
| - **`SCB_BOT_USER_TOKEN`** — GitHub token for the secureCodeBoxBot. | ||
| - **`SONAR_TOKEN`** — Token for SonarCloud. | ||
| - `CC_TEST_REPORTER_ID`: 🤷♂️ Not found in any repo nor password manager. |
There was a problem hiding this comment.
Please just delete the secret, we will never find out otherwise if its used
|
Sorry had a look over the changed and didn't read the PR description, but don't really get what we have by basically documenting something that we don't understand what it was used for. Either it breaks and we have to investigate what broke or they are unused and everything is fine. |
2 participants
So we have the names somewhere before deleting it. Just in case we need to restore them.
Description
Checklist