Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
mvanhorn
force-pushed
the
fix/3139-prevent-early-parser-start
branch
from
September 3, 2026 17:08
4b936d9 to
6265550
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Change
checkIfAllJobsCompletedso that a list containing no Jobs is explicitly incomplete; completion must require at least one observed Job and successful status for every observed Job. Keep the existing precedence in which anyBackoffLimitExceededJob reports failure and any non-succeeded Job reports incomplete, so all three production callers—the scanner, parser, and hook reconciliation paths—remain conservative during cache-observation gaps. Extend the existing table of focused helper tests with the empty-list case, while retaining coverage for all-succeeded, mixed/incomplete, and failed lists.The scan reconciler decides whether scanner, parser, and hook Jobs have finished through
checkIfAllJobsCompleted. That helper initializes its aggregate result as completed, so an empty Job list is interpreted as successful even though no Job has reported success. During the short interval in which the controller cache has not yet observed a newly created scanner Job, this can advance the Scan toScanCompletedand start the parser before the scanner uploads its raw result, producing an intermittent MinIONoSuchKeyerror. The maintainer reproduced the rare behavior and identified this helper as the relevant decision point.Closes #3139
Checklist