Add golang based hook-sdk - #3786
Merged
Merged
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
Weltraumschaf
force-pushed
the
feat/go-hook-sdk
branch
from
September 1, 2026 11:53
08f426d to
a0748c7
Compare
Weltraumschaf
requested changes
Sep 1, 2026
J12934
force-pushed
the
feat/go-hook-sdk
branch
from
September 8, 2026 15:33
c8ae534 to
c9a2d79
Compare
Weltraumschaf
approved these changes
Sep 8, 2026
github-project-automation
Bot
moved this from To Review
to Reviewer Approved
in secureCodeBox
Also migrate fpp hook to have a test / example golang hook Signed-off-by: Jannik Hollenbach <[email protected]>
Switchting back to additionalProperties: true to keep backwards compatability. Opened up secureCodeBox#3797 as a follow up. Signed-off-by: Jannik Hollenbach <[email protected]>
still properly passing Signed-off-by: Jannik Hollenbach <[email protected]>
- have the hook request implement the methods in a more straight forward way - pass in ctx into the hook function to keep best practices and ensure the funcs remain cancellable - include a test helper in the sdk to keep hook boilerplate out of the hooks Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
were previously validated case insensitivly without normilization afterwards Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
J12934
force-pushed
the
feat/go-hook-sdk
branch
from
September 9, 2026 06:33
725460e to
b050de3
Compare
|
github-project-automation
Bot
moved this from Reviewer Approved
to Done
in secureCodeBox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Also migrate fpp hook to have a test / example golang hook
We might migrate more hooks to golang in the future.
Checklist