Add retries for the raw result upload from the lurker sidecar - #3785
Merged
Merged
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
When upload fails it can be painful to retry the entire scan just to rerun the file upload. Signed-off-by: Jannik Hollenbach <[email protected]>
Contributor
|
The lurker keeps trying to upload the file even if the scan filed and there is no file to upload. The lurker should not do the retries if the findings file does not exist |
The scan container is already gone when the lurker starts up, if the file isn't there it won't appear later, so no point in retrying the fs call Signed-off-by: Jannik Hollenbach <[email protected]>
J12934
force-pushed
the
feat/lurker-upload-retries
branch
from
September 9, 2026 14:32
3a205d7 to
1d90286
Compare
![github-advanced-security[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Jannik Hollenbach <[email protected]>
|
Weltraumschaf
requested changes
Sep 10, 2026
Weltraumschaf
approved these changes
Sep 15, 2026
github-project-automation
Bot
moved this from To Review
to Reviewer Approved
in secureCodeBox
github-project-automation
Bot
moved this from Reviewer Approved
to Done
in secureCodeBox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When upload fails it can be painful to retry the entire scan just rerun the file upload.
Checklist