Skip to content

Commit ab49bd0

Browse files
authored
Merge pull request feast-dev#3 from leonid133/fix/registry_mkdirs
Fix/registry mkdirs
2 parents ecf2c18 + 89326ec commit ab49bd0

3 files changed

Lines changed: 7 additions & 10 deletions

File tree

sdk/python/feast/infra/aws_dynamo_provider.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,9 @@
2424

2525

2626
class AwsDynamoProvider(Provider):
27-
_aws_project_id: Optional[str]
2827

2928
def __init__(self, config: RepoConfig):
3029
assert isinstance(config.online_store, DynamoOnlineStoreConfig)
31-
if config and config.online_store and config.online_store.project_id:
32-
self._aws_project_id = config.online_store.project_id
33-
else:
34-
self._aws_project_id = None
3530

3631
def _initialize_dynamodb(self):
3732
return boto3.resource('dynamodb')

sdk/python/feast/registry.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -540,10 +540,13 @@ def _write_registry(self, registry_proto: RegistryProto):
540540
registry_proto.version_id = str(uuid.uuid4())
541541
registry_proto.last_updated.FromDatetime(datetime.utcnow())
542542
# we have already checked the bucket exists so no need to do it again
543-
registry_bucket = boto3.resource('s3').Bucket(self._bucket)
544-
registry_db = registry_bucket.Object(self._key)
545543
file_obj = TemporaryFile()
546544
file_obj.write(registry_proto.SerializeToString())
547545
file_obj.seek(0)
548-
registry_db.upload_fileobj(file_obj)
549-
return
546+
s3 = boto3.client('s3')
547+
s3.put_object(
548+
Bucket=self._bucket,
549+
Body=file_obj,
550+
Key=self._key
551+
)
552+
return

sdk/python/feast/repo_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ class DynamoOnlineStoreConfig(FeastBaseModel):
3838
"""Online store config for DynamoDB store"""
3939
type: Literal["dynamo"] = "dynamo"
4040
"""Online store type selector"""
41-
project_id: Optional[StrictStr] = None
4241

4342

4443
OnlineStoreConfig = Union[DatastoreOnlineStoreConfig, SqliteOnlineStoreConfig, DynamoOnlineStoreConfig]

0 commit comments

Comments
 (0)