Skip to content

Fixed Second PythonEngine.Initialize call, all sensitive static variables now reseted. #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmor merged 8 commits into from
Nov 14, 2018
Merged

Fixed Second PythonEngine.Initialize call, all sensitive static variables now reseted. #534

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b0c68e6
Runtime/Shutdown loop stores old caches and static variables. It's pr…
Aug 31, 2017
1dbf383
Added all tests finalizer routine.
Sep 2, 2017
ccd6003
Bug: Py_Initialize/Py_Finalize calls during alive PythonEngine. Fixed.
Sep 2, 2017
6a6414d
Init/Shutdown state variable (IsFinalizing) fix.
Sep 2, 2017
d3315d4
TestPythonEngineProperties fixes.
Sep 5, 2017
b2b4838
Update CHANGELOG.md
filmor Oct 16, 2018
d7f2bc8
Rename TestsSuite and add comment, remove unneeded using
filmor Oct 16, 2018
dbd5fdd
Update assemblymanager.cs
filmor Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bug: Py_Initialize/Py_Finalize calls during alive PythonEngine. Fixed.
  • Loading branch information
dse @filmor
dse authored and filmor committed Nov 14, 2018
commit ccd60034d6b7c065b49d9a4ad68d9eda96e97150
16 changes: 13 additions & 3 deletions src/embed_tests/TestRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
using System;
using System;
using NUnit.Framework;
using Python.Runtime;

namespace Python.EmbeddingTest
{
public class TestRuntime
{
[OneTimeSetUp]
public void SetUp()
{
// We needs to ensure that no any engines are running.
if (PythonEngine.IsInitialized)
{
PythonEngine.Shutdown();
}
}

/// <summary>
/// Test the cache of the information from the platform module.
///
Expand All @@ -24,12 +34,12 @@ public static void PlatformCache()

// Don't shut down the runtime: if the python engine was initialized
// but not shut down by another test, we'd end up in a bad state.
}
}

[Test]
public static void Py_IsInitializedValue()
{
Runtime.Runtime.Py_Finalize(); // In case another test left it on.
Runtime.Runtime.Py_Finalize();
Assert.AreEqual(0, Runtime.Runtime.Py_IsInitialized());
Runtime.Runtime.Py_Initialize();
Assert.AreEqual(1, Runtime.Runtime.Py_IsInitialized());
Expand Down