chore: regenerate the incoming field order and retire remaining 2009 fingerprints - #1894
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you agree that this new contribution is offered under Apache 2.0. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase |
Merging this PR will improve performance by 8.33%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_sending_packets |
112.7 µs | 104 µs | +8.33% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing tenth_audit_residue (e75425e) with master (d5f4102)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 33 33
Lines 3911 3910 -1
Branches 568 568
==========================================
- Hits 3906 3905 -1
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Summary
Follow-up to the tenth independent audit of the #1835 removal claims: retires the remaining 2009 fingerprints it flagged outside the probe and request loops.
Details
DNSIncoming.__init__still initialized its shared fields in the 2009 sequence; the assignments are regenerated under the same rule asDNSOutgoingin chore: rework the remaining shapes flagged by the sixth independent audit #1889 (public fields alphabetical, then private fields alphabetical). Assignment order is behavior neutral and the.pxdowns the struct layout.entry_to_stringandto_stringcompatibility shims kept the 2009 parameter names and the append-then-format shape. The optional data payload now lives in_format_displayitself, both shims collapse to single delegating lines, and the parameters are renamed.test_browser.pymatched the 2009 line byte for byte including its parentheses; it now matches the production formula instead.pyproject.tomlstill allow-listed_GLOBAL_DONE, a 2009 global that no longer exists in the tree.Test plan
REQUIRE_CYTHON=1rebuild: 518 passed