chore: rework the remaining shapes flagged by the sixth independent audit - #1889
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you agree that this new contribution is offered under Apache 2.0. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1889 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3910 3910
Branches 568 568
=======================================
Hits 3905 3905
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Follow-up to the sixth independent audit of the #1835 removal claims. Reworks the last flagged shapes: the
DNSOutgoing.__init__field initialization sequence (0.83 token similarity to the 2009 constructor), the one surviving five word prose run, and the docstrings still scoring 0.60-0.65 against removed text.Details
DNSOutgoing.__init__and_reset_for_next_packetnow set fields in rule generated order: alphabetical within each group, except the four section lists, which keep RFC 1035 section 4.1 order (question, answer, authority, additional) with a citation comment. Assignment order is behavior neutral and the struct layout is owned by the.pxd, which is untouched.write()rdata docstrings and the_set_created_ttldocstring are deleted rather than reworded: the four siblingwrite()overrides carry no docstring, so deletion is the consistent form and removes the similarity entirely.async_wait's docstring is reworded away from the removed 2009 phrasing.Test plan
REQUIRE_CYTHON=1rebuild: 516 passed