Skip to content

chore: rework the remaining shapes flagged by the sixth independent audit - #1889

Merged
bdraco merged 1 commit into
masterfrom
sixth_audit_residue
Aug 30, 2026
Merged

bdraco merged 1 commit into
masterfrom
sixth_audit_residue

Conversation

@bdraco

@bdraco bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to the sixth independent audit of the #1835 removal claims. Reworks the last flagged shapes: the DNSOutgoing.__init__ field initialization sequence (0.83 token similarity to the 2009 constructor), the one surviving five word prose run, and the docstrings still scoring 0.60-0.65 against removed text.

Details

  • DNSOutgoing.__init__ and _reset_for_next_packet now set fields in rule generated order: alphabetical within each group, except the four section lists, which keep RFC 1035 section 4.1 order (question, answer, authority, additional) with a citation comment. Assignment order is behavior neutral and the struct layout is owned by the .pxd, which is untouched.
  • The known answer suppression docstring loses the shared "is at least half of" phrase and now matches the strict comparison in the code ("more than half our TTL"), still citing RFC 6762 section 7.1.
  • The two write() rdata docstrings and the _set_created_ttl docstring are deleted rather than reworded: the four sibling write() overrides carry no docstring, so deletion is the consistent form and removes the similarity entirely.
  • async_wait's docstring is reworded away from the removed 2009 phrasing.
  • The probe pacing loop the same audit flagged is restructured separately in refactor: compute probe pacing from fresh clock reads #1888.

Test plan

  • full compiled test suite after REQUIRE_CYTHON=1 rebuild: 516 passed
  • pre-commit clean

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

@bdraco
bdraco marked this pull request as ready for review August 30, 2026 01:13
@codspeed

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing sixth_audit_residue (4e8cbe7) with master (ae524a5)

Open in CodSpeed

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (f0a20a0) to head (4e8cbe7).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1889   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3910     3910           
  Branches      568      568           
=======================================
  Hits         3905     3905           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco
bdraco merged commit bfc1af2 into master Aug 30, 2026
37 checks passed
@bdraco
bdraco deleted the sixth_audit_residue branch August 30, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant