chore: enforce the declaration ordering convention in ci - #1887
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you agree that this new contribution is offered under Apache 2.0. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1887 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3910 3910
Branches 568 568
=======================================
Hits 3905 3905
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
348072c to
dd9091d
Compare
|
The one line codecov flags (record_manager.py:68, the failed to remove listener log) predates this PR and is currently unreachable: listeners is a set, so removing an unregistered listener raises KeyError while the handler catches ValueError, a leftover from the list days. #1783 addresses that behavior; covering the line belongs there rather than in this declaration move. |
Summary
Follow up to #1886. The fifth audit showed the ordering convention can regress silently (#1880 broke it in three classes), so it is now enforced and fully documented:
Test plan