chore: fresh record display formats - #1880
Merged
Merged
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3882 3909 +27
Branches 567 568 +1
=======================================
+ Hits 3877 3904 +27
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bdraco
force-pushed
the
remove_2009_repr_formats
branch
from
August 29, 2026 23:05
ab09b75 to
d84dd4f
Compare
bdraco
force-pushed
the
replace_2009_repr_formats
branch
from
August 29, 2026 23:05
bcb4a14 to
895921a
Compare
bdraco
force-pushed
the
remove_2009_repr_formats
branch
from
August 29, 2026 23:14
d84dd4f to
5584f3c
Compare
bdraco
force-pushed
the
replace_2009_repr_formats
branch
from
August 29, 2026 23:14
895921a to
acb0afe
Compare
bdraco
force-pushed
the
replace_2009_repr_formats
branch
4 times, most recently
from
August 29, 2026 23:30
554ecf9 to
8de8a13
Compare
bdraco
force-pushed
the
replace_2009_repr_formats
branch
from
August 29, 2026 23:31
8de8a13 to
30bc14f
Compare
bdraco
marked this pull request as ready for review
August 29, 2026 23:31
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #1878 for #1835, revised after a counsel style review of the first draft: the textual format is fresh AND the implementation architecture is independently redesigned rather than restoring the 2009 delegation chain. Display is one module level formatter over structured field collections, with type and class labels as properties and each record class contributing its own field tuples; question reprs move off the 2009 bracket layout to the same field format.
The four public names from the old family (get_type, get_class_, entry_to_string, to_string) remain as permanent thin compatibility shims over the new formatter, since API names are not copyrightable and dropping public methods would break downstream consumers; nothing internal calls them.
Sample output: <DNSService name=demo._http._tcp.local. type=srv class=in ttl=120 (119 remaining) server=host.local. port=8080>
Seven tests pinning old format substrings were updated.
Test plan