test: make test_qu_response deterministic by injecting the announcement - #1845
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1845 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3883 3883
Branches 567 567
=======================================
Hits 3878 3878
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_qu_responseflaked on the macOS 3.11 skip_cython job withmcast_nowempty in the probe phase.Details
The test registered the service with
register_service, which announces on loopback;register_servicewaits for the sends but the loopback receive of the last announcement is processed on the loop thread afterwards. On a slow runner it lands after_clear_cache, the PTR becomes recent again, and the QU probe answer goes to unicast only. The first phase had the mirror race since it needs the announcement cached.The service is now added to the registry directly and the announcement is injected with
_inject_response, the same pattern the rest oftest_handlers.pyuses, so nothing arrives from the wire mid test.Test plan
tests/test_handlers.py::test_qu_responsepasses on repeated runs