chore: restore behavior with freshly authored replacements - #1844
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1844 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 33 33
Lines 3883 3882 -1
Branches 567 567
==========================================
- Hits 3878 3877 -1
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bdraco
force-pushed
the
remove_nonconsented_src
branch
from
August 29, 2026 19:00
3b2b1e5 to
6bed3cd
Compare
bdraco
force-pushed
the
restore_fresh_expression
branch
from
August 29, 2026 19:00
7713ef0 to
f702e80
Compare
bdraco
marked this pull request as ready for review
August 29, 2026 19:07
bdraco
force-pushed
the
restore_fresh_expression
branch
from
August 29, 2026 19:08
bbbf8c9 to
cb940f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the behavior deleted in #1843 with freshly written code for #1835. Everything here is new expression; the const tables and header flag constants were rewritten with fresh comments, the
_dnsrecord helpers and abstract raisers were reauthored, the outgoing writer paths were reimplemented, and the two example scripts are brand new files. No deletions in this PR, those all live in #1843.Details
_write_recordnow derives the rdata length from thesizecounter instead of rescanning the data chunks.pxdlocals were updated alongside the new variable names inoutgoing.pyTest plan
REQUIRE_CYTHON=1rebuild, 514 passed