fix: restore sdist contents and listener typing after the reverts - #1839
Merged
Merged
Conversation
bdraco
force-pushed
the
restore_after_revert
branch
from
August 29, 2026 15:22
b7fe208 to
731160f
Compare
bdraco
marked this pull request as ready for review
August 29, 2026 15:22
bdraco
force-pushed
the
restore_after_revert
branch
from
August 29, 2026 15:22
731160f to
f491259
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1839 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3883 3883
Branches 567 567
=======================================
Hits 3878 3878
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1838; restores the two behaviors the reverts removed, written fresh.
Details
_respond_queryin_listener.pxdis declared on a single line with theDNSIncomingtyping current Cython requiresgit blameshows no remaining lines from the non consenting contributorTest plan
REQUIRE_CYTHON=1build succeeds; full suite passespoetry buildsdist verified to contain COPYING, CHANGELOG.md, docs, and tests