test: allow coverage data lock in blockbuster - #1828
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1828 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 33 33
Lines 3799 3799
Branches 543 543
=======================================
Hits 3792 3792
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_update_recordflaked on windows 3.12 withBlockingError: Blocking call to lock.acquireinside_ServiceBrowserBase._async_start; the acquire came from coverage's C tracer (coverage/collector.pylock_data), which grabs its data lock from whatever frame is running when tracing starts on a new thread, so the browser callback died, no service was added, and the browser threads leaked into teardown.Details
Lock.acquire; the race needs another thread holding coverage's data lock at the moment the tracer fires in an event loop frame, which is why it only shows up occasionallythreading.Lock.acquireandacquire_lockwhen the frame islock_dataincoverage/collector.py; blockbuster normalizes frame paths withas_posix, so the match also works on windowsTest plan
coverage/collector.pyfilename and a held lock; without the fix it raisesBlockingError, with the fix it is allowed, and a contended acquire from any other frame still raisestests/services/test_browser.pypasses locally