Conversation
…ibrary 10.5.0 stopped checking, after a build, whether every value happened to be the same: "GrB_Matrix_build and GrB_Vector_build: no longer do a post-iso check; they leave the matrix in non-iso format even if all the entries are the same." Four tests read that check as if it were python-graphblas's own contract and went red. Each one wanted an iso object rather than an inference, so each now asks for one with ``ss.build_scalar``, which means the same thing on every SuiteSparse version and produces the same storage formats the tests were selecting for. ``from_coo`` is left alone: adding a scan of the values to recover the old behavior would re-add the cost upstream just removed. The version gates had a second, quieter problem. ``graphblas.core.ss`` derived the C library version by parsing ``suitesparse_graphblas.__version__``, which is the version of the Python wrapper. The two normally agree, but a development build between releases reports the previous one: psg 10.4.1.0 against a 10.5.0 library here, so every gate saw 10.4.1 and any 10.5 branch would have been silently skipped. Read the library's own GxB_IMPLEMENTATION_* constants instead, falling back to the old parse where a build does not expose them. test_openmp_enabled keeps its hard assertion and gains a message saying what is wrong and that the fault is in the installed build. It caught a real one: conda-forge's first graphblas 10.5.0 build on osx-arm64 shipped without OpenMP. The build 1 rebuild (2026-08-26) restored OpenMP and the assertion passes again.
The pool stopped at psg 10.3.1.0, so CI installed nothing newer except on the draw that picks "latest", which does not pin and so never produces a reproducible combination. Three releases have landed since, and each carries a SuiteSparse:GraphBLAS this project has to work against: 10.4.0 moved a field in the matrix struct, and 10.5.0 dropped the post-build iso check that four tests used to rely on. psg 10.5.0.0 is on PyPI and, since 2026-08-26, on conda-forge, so the conda-forge, wheel and source draws all cover it. `scripts/check_versions.sh` tracks the newest version we test, so its psg floor moves with the pool. Only the psg pools change here. The other pools are revised further up this branch stack, so raising them belongs there rather than in a commit that would conflict with every rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #628. Second rung below the pre-existing stack; sits between #628 and #587.
The pool stopped at psg 10.3.1.0, so CI installed nothing newer except on the draw that picks "latest", which does not pin and so never produces a reproducible combination. Three releases have landed since, and each carries a SuiteSparse:GraphBLAS this project has to work against: 10.4.0 moved a field in the matrix struct, and 10.5.0 dropped the post-build iso check that four tests used to rely on.
psg 10.5.0.0 is on PyPI and, since 2026-08-26, on conda-forge, so the conda-forge, wheel and source draws all cover it.
scripts/check_versions.shtracks the newest version we test, so its psg floor moves with the pool.Only the psg pools change here. The other pools are revised further up the stack (#631), so raising them belongs there rather than in a commit that would conflict with every rebase.
Note on placement: this sits BELOW rung 07 so that every rung's CI can draw SuiteSparse 10.4/10.5 against the adaptations in #628. Until #628 and this PR merge into main, #587's Files tab also shows these two commits (the stack manager would not allow retargeting #587's base); it self-heals once these merge.