Add concrete NEWS entry examples - #1906
Open
muhammad-a-dev wants to merge 5 commits into
Open
muhammad-a-dev wants to merge 5 commits into
muhammad-a-dev wants to merge 5 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
|
Member
|
Please sign the CLA, it's necessary before we can review. This section seems to duplicate some content we have in the current section for news entries. The new proposed section also isn't linked there. |
StanFromIreland
marked this pull request as draft
September 17, 2026 06:39
Author
|
Thanks @StanFromIreland — I've moved the examples into the existing "Changes that require NEWS entries" section in |
muhammad-a-dev
marked this pull request as ready for review
September 17, 2026 09:04
hugovk
marked this pull request as draft
September 17, 2026 09:11
Author
|
CLA is signed now — bot shows all commit authors covered. |
muhammad-a-dev
marked this pull request as ready for review
September 17, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1243.
Inlines concrete do / don't NEWS entry examples under the existing Changes that require NEWS entries section in
getting-started/pull-request-lifecycle.rst(from @ezio-melotti's review note on #1238):This keeps the examples with the current NEWS guidance instead of a separate sibling page.
Prerequisite #674 is already closed (NEWS guidance lives in the lifecycle page after #1506).
AI tools
Drafted with assistance from Cursor (AI); I reviewed the wording against the issue text and existing NEWS guidance before opening this PR.