gh-91398: Remove IDLE shell sidebar padding - #32363
Conversation
I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions. Changing this line of code solves this issue and leaves the color choices up to the user.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
This only affects the shell sidebar, which is the subject of bpo-45451. I made the change I requested.
On my Windows with dark theme, I prefer the change. But change needs evaluation on light and dark themes on all 3 major OSes. Will ask OP of issue for opinion. So not approved yet.
terryjreedy
changed the title
terryjreedy
added
type-bug
|
@ambv This should be linked to the new GH issue when available. I overwrote the proposed change and will add blurb before merging. |
|
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |
|
Hey, just updated to 3.12 and it seems this change still hasn't gone through. Updates? |
@terryjreedy Just a little reminder :) Is it possible for you to run all the actions (I do not have the permissions to do this) so we can see the current state of the PR? |
I think this looks great! |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @BA-24 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-157574 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-157575 is a backport of this pull request to the 3.14 branch. |
|
GH-157576 is a backport of this pull request to the 3.13 branch. |
10 participants
I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions.
Changing this line of code solves this issue and leaves the color choices up to the user.
#89614, #91398