Skip to content

bpo-45573: Move mandatory core modules to Modules/Setup.bootstrap (GH-29616) #29616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiran merged 5 commits into from
Nov 19, 2021
Merged

bpo-45573: Move mandatory core modules to Modules/Setup.bootstrap (GH-29616) #29616

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a613d44
bpo-45573: Move mandatory core modules to Modules/Setup.core
tiran Nov 18, 2021
8c29e52
Use Setup.bootstrap
tiran Nov 19, 2021
e11c9b6
Fix comment
tiran Nov 19, 2021
e749a53
Single quotes don't work
tiran Nov 19, 2021
db3e45e
Consolidate comments about extensions in Setup.bootstrap
tiran Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Consolidate comments about extensions in Setup.bootstrap
  • Loading branch information
@tiran
tiran committed Nov 19, 2021
commit db3e45e1659767efc997c77c93f6c9611cfe3f94
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,6 @@ def detect_simple_extensions(self):
if lib:
time_libs.append(lib)

# time module is built by Modules/Setup.bootstrap
# libm is needed by delta_new() that uses round() and by accum() that
# uses modf().
self.addext(Extension('_datetime', ['_datetimemodule.c']))
Expand All @@ -1031,7 +1030,6 @@ def detect_simple_extensions(self):
self.add(Extension('_opcode', ['_opcode.c']))
# asyncio speedups
self.add(Extension("_asyncio", ["_asynciomodule.c"]))
# _abc module is built by Modules/Setup.bootstrap
# _queue module
self.add(Extension("_queue", ["_queuemodule.c"]))
# _statistics module
Expand All @@ -1050,7 +1048,6 @@ def detect_simple_extensions(self):
libs = ['bsd']
self.add(Extension('fcntl', ['fcntlmodule.c'],
libraries=libs))
# pwd module is built by Modules/Setup.bootstrap
# grp(3)
if not VXWORKS:
self.add(Extension('grp', ['grpmodule.c']))
Expand Down Expand Up @@ -1505,6 +1502,9 @@ def detect_modules(self):
self.configure_compiler()
self.init_inc_lib_dirs()

# Some C extensions are built by entries in Modules/Setup.bootstrap.
# These are extensions are required to bootstrap the interpreter or
# build process.
self.detect_simple_extensions()
if TEST_EXTENSIONS:
self.detect_test_extensions()
Expand Down