gh-69365: Show search pattern errors in the IDLE search dialogs - #157598
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Show the error in red below the entry and move the cursor to the offending character in the pattern, instead of a message box. Find Again without a dialog still uses the message box. Check the pattern as typed, so that the position is right. This also fixes the "Whole word" option with a regular expression: the pattern is now grouped, so that "a|b" is anchored on both sides, and a pattern ending with a backslash is an error instead of matching "\b". Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Member
|
Unrelated failure: (rerunning) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Find, Replace and Find in Files dialogs now show a regular expression error in red below the entry, as the Open Module dialog does, and move the cursor to the offending character, instead of a message box that has to be dismissed first. The message is cleared when the pattern is edited. Find Again without a dialog still uses the message box.
The pattern is now checked as typed, so that the position is right. This also fixes the "Whole word" option with a regular expression: the pattern is grouped, so that
a|bis anchored on both sides, and a pattern ending with a backslash is an error instead of matching\b. Global flags like(?i)cannot be used with "Whole word"; the error message now says so.🤖 Generated with Claude Code