gh-105689: Parse only the current statement in the IDLE Shell - #157594
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Since the prompts moved to the sidebar, sys.ps1 ends with a newline and prompt_last_line is empty, so HyperParser and newline_and_indent took the editor path in the Shell and parsed previous output. Use an explicit is_shell attribute instead. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the prompts moved to the sidebar in 3.10,
sys.ps1ends with a newline andprompt_last_lineis empty, soHyperParserandnewline_and_indent_eventtook the editor path in the Shell and scanned back through previous output. Unbalanced quotes or parentheses in that output — a traceback forraise ValueError("""\n"""), aSyntaxError: '(' was never closed— then broke calltips, parenthesis matching and auto-indent for everything typed afterwards. Use an explicitis_shellattribute and parse only the current statement in the Shell, as before 3.10. This also fixes the Shell examples of #124451.🤖 Generated with Claude Code