Conversation
Handle unexpected exceptions in can_colorize instead of surfacing them in the REPL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
This pull request improves the robustness of the
_colorizemodule by making the colorization detection logic more resilient to unexpected exceptions when checking if a file is a TTY. It also adds a new test to ensure this behavior is correctly handled when files are closed.Robustness improvements:
can_colorizelogic in_colorize.pyto catch all exceptions (not justOSError) when checking if a file is a TTY, returningFalseif any exception occurs. This prevents crashes in edge cases, such as when a file is closed.Test coverage enhancements:
test__colorize.pyto verify thatcan_colorizereturnsFalsefor closed files, ensuring correct behavior for files that raiseValueErroronfileno().tempfileintest__colorize.pyto support the new test case for closed files.sys.stdoutcauses an endless stream of tracebacks in the repl #157581