Repository navigation
fix(edge): preserve JSON-RPC batch envelopes - #321
Merged
punkpeye merged 3 commits intoAug 12, 2026
Merged
Conversation
|
🎉 This PR is included in version 4.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the JSON-RPC batch envelope in the Edge transport based on the shape of the original request, rather than the number of response objects that remain after notifications are omitted.
This follows JSON-RPC 2.0 batch semantics:
[]) is invalid and returns one response object (not an array) with HTTP 200, error-32600, andid: null;application/json;Implementation
The diff is limited to
src/edge/index.tsandsrc/edge/edge.test.ts; package manifests and the lockfile are unchanged. This branch is based directly onmainatv4.14.4after #320 merged.Verification
Fresh RED on
v4.14.4with the tests only:[]returned HTTP 202 instead of an Invalid Request object.GREEN on this head:
tsc --noEmit: pass;