Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds ChangesCurve Geometry Constructors
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant SQL
participant LWGEOM_makecurveline_garray
participant LWGEOM_makecompoundcurve_garray
participant GeometrySerializer
SQL->>LWGEOM_makecurveline_garray: pass point geometry array
LWGEOM_makecurveline_garray->>LWGEOM_makecurveline_garray: validate points, SRIDs, dimensions, and count
LWGEOM_makecurveline_garray->>GeometrySerializer: serialize CIRCULARSTRING
SQL->>LWGEOM_makecompoundcurve_garray: pass curve geometry array
LWGEOM_makecompoundcurve_garray->>LWGEOM_makecompoundcurve_garray: validate components, SRIDs, dimensions, and joins
LWGEOM_makecompoundcurve_garray->>GeometrySerializer: serialize COMPOUNDCURVE
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@NEWS`:
- Around line 50-51: The release note for issue `#1291` incorrectly groups all
three functions (ST_MakeCurveLine, ST_MakeCompoundCurve, and ST_MakePolygon)
under "curved rings support", which misrepresents their scope. Reword the bullet
point to separate ST_MakeCurveLine and ST_MakeCompoundCurve as general curve
constructors from ST_MakePolygon, which specifically adds curved-ring support.
This clarification ensures readers understand that only ST_MakePolygon is
related to curved rings while the other two are broader curve-building
functions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7f23ee2a-29e0-46d8-9979-639cb161d9e3
📒 Files selected for processing (6)
NEWSdoc/reference_constructor.xmlpostgis/lwgeom_functions_basic.cpostgis/postgis.sql.inregress/core/ctors.sqlregress/core/ctors_expected
Komzpa
marked this pull request as draft
June 22, 2026 06:44
Komzpa
force-pushed
the
codex/ticket-1291-curve-constructors
branch
3 times, most recently
from
July 6, 2026 12:01
72a41da to
36b0040
Compare
Komzpa
force-pushed
the
codex/ticket-1291-curve-constructors
branch
2 times, most recently
from
July 9, 2026 12:45
d83f962 to
b40bb13
Compare
Komzpa
force-pushed
the
codex/ticket-1291-curve-constructors
branch
from
July 17, 2026 22:41
b40bb13 to
990b596
Compare
Komzpa
force-pushed
the
codex/ticket-1291-curve-constructors
branch
4 times, most recently
from
July 28, 2026 21:32
a880a97 to
9787666
Compare
Komzpa
force-pushed
the
codex/ticket-1291-curve-constructors
branch
from
August 2, 2026 07:59
9787666 to
0777f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ST_MakeCurveLineconstructors for three points and point arraysST_MakeCompoundCurvefor continuous LineString, CircularString, and NURBSCurve arraysST_MakePolygonscopeTrac ticket: https://trac.osgeo.org/postgis/ticket/1291
Validation on rebased head
5cf192375509fd1fd11299c26913781046cb2710./autogen.sh && ./configure --with-jsondir=/usr --with-projdir=/usr --with-raster --with-topology --with-sfcgalmake postgis_revision.hmake -C postgis -j32make -C extensions postgis_extension_helper.sqlmake -B -C extensions/postgis sql/postgis_for_extension.sql sql/postgis--3.7.0dev.sqlmake -C extensions/postgis -j1sudo -n make -C postgis installsudo -n make -C extensions/postgis installmake -C regress check RUNTESTFLAGS="--extension --verbose" TESTS="$(pwd)/regress/core/ctors"(fresh and upgrade:Run tests: 3,Failed: 0)make -C doc check-xmlmake check-news && ./utils/check_news.sh .git clang-format --diff upstream/master -- postgis/lwgeom_functions_basic.c postgis/postgis.sql.in doc/reference_constructor.xml regress/core/ctors.sql regress/core/ctors_expected NEWSgit diff --check upstream/master..HEAD && git diff --check && git diff --cached --check