Repository navigation
fix(ci): a failed yarn run is not a dependency install (#359) - #360
Merged
PabloCodes7 merged 1 commit intoJul 14, 2026
Merged
Conversation
yarn classic ends every command with `info Visit https://yarnpkg.com/en/docs/cli/<cmd> for documentation about this command.`, and node_dependency_install matched the bare host. A failed `yarn run prettier` / `yarn lint` / `yarn test` therefore scored a dependency verdict on a documentation link. facebook/react run 29335289512 (the "Run prettier" step) failed on a formatting diff and was sent back to reconcile a lockfile. Pin the footer to the two subcommands that ARE a dependency operation (install, add); the run/lint/test footers no longer match, so the log's real prettier witness wins and it answers javascript_lint. Real yarn install failures keep the /cli/install footer and their other signals. Regression test with a negative case (install/add footers still land node_dependency_install); real-log excerpt committed; benchmark 221/221 unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359.
The bug
yarn classic ends every command with
info Visit https://yarnpkg.com/en/docs/cli/<cmd> for documentation about this command., andnode_dependency_installmatched the bare hostyarnpkg.com. So a failedyarn run prettier/yarn lint/yarn testscored a dependency verdict on a documentation link and the maintainer was told to reconcile a lockfile.facebook/react's "Run prettier" step, run 29335289512, failed because a file wasn't formatted. The footer was
/cli/run, not/cli/install. Reproduces identically on 0.6.1 through 0.7.1:Here
node_dependency_installandjavascript_linteach match exactly one witness (the footer vsprettier), and the dependency rule wins the tie on rule order.The fix
One regex in
classify.py: pin the footer to the two subcommands that are a dependency operation (install,add). Therun/lint/testfooters no longer match, so the log's realprettierwitness wins:Real
yarn installfailures keep their/cli/installfooter (and the older/lang/en/…/installform), plus their other strong signals — untouched.Evidence
tests/test_yarn_run_footer_notice.py: the react excerpt →javascript_lint; the footer line alone is no longer a dependency verdict; and a negative subtest keepsinstall/add//lang/en/…installfooters landingnode_dependency_install.examples/real-world/react-29335289512-excerpt.log; benchmark page and CHANGELOG updated.