Skip to content

An ##[error] annotation that announces a success is reported as somewhere to "start" #329

Description

@PabloCodes7

Found dogfooding the 0.6.0 wheel from PyPI against a real failing run (oven-sh/bun, run 29324834075).

The log carries exactly one runner annotation, and the workflow emits a success message through the error channel:

##[error]✅ Autofix task started.

runner_errors (new in 0.6.0) faithfully reports whatever the runner marked as an error, so the unknown verdict renders:

## Errors the runner reported
No rule matched this log, so PatchRail did not classify it. The CI runner did annotate these lines as errors — start there:
- `✅ Autofix task started.`

Telling someone to "start there" on a line that says a task started fine is a dead end wearing a suit — the exact failure mode _RUNNER_ERROR_BOILERPLATE was added to prevent (#324), just arriving through content rather than through the runner’s own template.

The verdict itself is right: unknown is correct for this log (0.5.0 called it node_dependency_install 0.53 on the strength of a lockfile/ path token; 0.6.0 correctly declines). Only the annotation we hand back is unhelpful.

Worth deciding, not assuming: filtering annotations whose content reads as a success (leading ✅/✔, Autofix task started) is narrow and safe, but any content heuristic risks dropping a real error that happens to contain a checkmark. An alternative is to keep reporting it and let the empty-handed case stand.

Repro:

gh run view 29324834075 --repo oven-sh/bun --log-failed | patchrail ci explain --format markdown

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions