Skip to content

Add react with vite example - #261

Merged
Jiannan-dev merged 2 commits into
originjs:mainfrom
nefayran:main
Oct 20, 2022
Merged

Jiannan-dev merged 2 commits into
originjs:mainfrom
nefayran:main

Conversation

@nefayran

Copy link
Copy Markdown
Contributor

Description

Add example for implement micro-frontend application with vite-plugin-federation and react.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Jiannan-dev

Copy link
Copy Markdown
Collaborator

image

It looks like it's caused by not uploading the pnpm-lock file

@Jiannan-dev

Copy link
Copy Markdown
Collaborator

image

This looks good, thanks

@Jiannan-dev
Jiannan-dev merged commit 4445932 into originjs:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants