Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved moderate and critical findings affect benchmark mappings, client behavior, and setup documentation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (11)
What changed in this PR
Replaces unsupported resnet-binary references with the standard ResNet50 INT8 model across documentation, demos, and client samples.
Changes:
- Updates model downloads, tensor names, preprocessing, and deployment examples.
- Refreshes MediaPipe, image-classification, and benchmark configurations.
- Removes legacy performance tooling and TFS benchmark support.
| File | Reviewed change |
|---|---|
tests/performance/README.md |
Removes legacy performance documentation. |
tests/performance/grpc_throughput.sh |
Removes throughput helper. |
tests/performance/grpc_start_one_stream.sh |
Removes stream helper. |
tests/performance/grpc_latency.py |
Removes latency client. |
tests/performance/download_model.sh |
Removes legacy model downloader. |
src/example/SampleCpuExtension/README.md |
Updates sample model setup. |
Makefile |
Removes performance targets. |
docs/starting_server.md |
Updates ResNet deployment instructions. |
docs/model_server_rest_api_kfs.md |
Updates metadata examples. |
docs/metrics.md |
Updates model configuration examples. |
docs/dynamic_shape_binary_inputs.md |
Updates binary-input model setup. |
docs/developer_guide.md |
Updates inference and debugging instructions. |
docs/deploying_server_docker.md |
Updates Docker deployment examples. |
docs/deploying_server_baremetal.md |
Updates bare-metal deployment examples. |
demos/mediapipe/image_classification/resnetMediapipe/subconfig.json |
Adds preprocessing settings. |
demos/mediapipe/image_classification/resnetMediapipe/graph.pbtxt |
Updates MediaPipe tensor names. |
demos/mediapipe/image_classification/README.md |
Updates model instructions. |
demos/image_classification/python/README.md |
Updates Python demo instructions. |
demos/benchmark/python/sample_data/graph.pbtxt |
Updates benchmark model selection. |
demos/benchmark/python/sample_data/config.json |
Updates benchmark model configuration. |
demos/benchmark/python/README.md |
Updates benchmark instructions. |
demos/benchmark/python/main.py |
Removes TFS client selection. |
demos/benchmark/python/Dockerfile |
Updates the benchmark image. |
demos/benchmark/python/client_tfs.py |
Removes the TFS client. |
demos/benchmark/python/client_kfs.py |
Updates status handling. |
client/python/kserve-api/samples/README.md |
Updates Python client examples. |
client/python/kserve-api/samples/http_infer_resnet.py |
Updates HTTP tensor defaults. |
client/python/kserve-api/samples/http_infer_binary_resnet.py |
Updates binary HTTP defaults. |
client/python/kserve-api/samples/http_async_infer_resnet.py |
Updates asynchronous HTTP defaults. |
client/python/kserve-api/samples/grpc_infer_resnet.py |
Updates gRPC tensor defaults. |
client/python/kserve-api/samples/grpc_infer_binary_resnet.py |
Updates binary gRPC defaults. |
client/python/kserve-api/samples/grpc_async_infer_resnet.py |
Updates asynchronous gRPC defaults. |
client/java/kserve-api/src/main/java/clients/grpc_infer_resnet.java |
Updates the Java input name. |
client/java/kserve-api/README.md |
Updates Java deployment instructions. |
client/go/kserve-api/README.md |
Updates Go deployment instructions. |
client/go/kserve-api/grpc_infer_resnet.go |
Updates the Go input name. |
client/go/kserve-api/build.sh |
Adds proxy build arguments. |
client/cpp/kserve-api/samples/http_infer_resnet.cpp |
Updates C++ HTTP defaults. |
client/cpp/kserve-api/samples/http_async_infer_resnet.cpp |
Updates asynchronous HTTP defaults. |
client/cpp/kserve-api/samples/grpc_infer_resnet.cpp |
Updates C++ gRPC defaults. |
client/cpp/kserve-api/samples/grpc_async_infer_resnet.cpp |
Updates asynchronous gRPC defaults. |
client/cpp/kserve-api/README.md |
Updates C++ deployment and sample instructions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mzegla
reviewed
Sep 21, 2026
przepeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-193417
Resnet-binary is now our of support and it doesn't work properly, it was decided to remove it and use usual resnet instead.
🧪 Checklist
``