Repository navigation
Conversation
The external-service-availability monitor probed https://static.redhat.com/test/rhel-networkmanager.txt once per second in every job registering the default monitor tests. The hostname resolves to both IPv4 and IPv6 addresses, but some CI build infrastructure has no IPv6 connectivity, so the probe failed intermittently and produced misleading ci-cluster-network-liveness disruption signal. The generic endpoint is redundant: equivalent static endpoint monitoring already exists per cloud via the AWS, Azure, and GCP external cloud service monitors, which remain registered. Co-Authored-By: Claude Opus 5 <[email protected]>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@jogeo: This pull request references OCPQUAL-55 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe stable monitor registry no longer includes the generic external-service availability monitor. Its test framework implementation is deleted. The separate GCP, AWS, and Azure availability monitors remain registered. ChangesGeneric external-service monitor removal
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The generic probe is removed as intended, while cloud-specific availability monitoring remains in place. No actionable merge risk is identified. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, jogeo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling tests matching the |
|
/retest |
|
@jogeo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The external-service-availability monitor probed
https://static.redhat.com/test/rhel-networkmanager.txt once per second in every job registering the default monitor tests. The hostname resolves to both IPv4 and IPv6 addresses, but some CI build infrastructure has no IPv6 connectivity, so the probe failed intermittently and produced misleading ci-cluster-network-liveness disruption signal.
The generic endpoint is redundant: equivalent static endpoint monitoring already exists per cloud via the AWS, Azure, and GCP external cloud service monitors, which remain registered.
Summary by CodeRabbit