Skip to content

OCPQUAL-55: remove static.redhat.com disruption monitor - #31685

Open
jogeo wants to merge 1 commit into
openshift:mainfrom
jogeo:OCPQUAL-55
Open

jogeo wants to merge 1 commit into
openshift:mainfrom
jogeo:OCPQUAL-55

Conversation

@jogeo

@jogeo jogeo commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

The external-service-availability monitor probed
https://static.redhat.com/test/rhel-networkmanager.txt once per second in every job registering the default monitor tests. The hostname resolves to both IPv4 and IPv6 addresses, but some CI build infrastructure has no IPv6 connectivity, so the probe failed intermittently and produced misleading ci-cluster-network-liveness disruption signal.

The generic endpoint is redundant: equivalent static endpoint monitoring already exists per cloud via the AWS, Azure, and GCP external cloud service monitors, which remain registered.

Summary by CodeRabbit

  • Changes
    • The generic external-service availability monitor is no longer included in the default stable monitor set. Separate availability monitors for GCP, AWS, and Azure remain available.

The external-service-availability monitor probed
https://static.redhat.com/test/rhel-networkmanager.txt once per second in
every job registering the default monitor tests. The hostname resolves to
both IPv4 and IPv6 addresses, but some CI build infrastructure has no IPv6
connectivity, so the probe failed intermittently and produced misleading
ci-cluster-network-liveness disruption signal.

The generic endpoint is redundant: equivalent static endpoint monitoring
already exists per cloud via the AWS, Azure, and GCP external cloud service
monitors, which remain registered.

Co-Authored-By: Claude Opus 5 <[email protected]>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 29, 2026 •

Copy link
Copy Markdown

@jogeo: This pull request references OCPQUAL-55 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

The external-service-availability monitor probed
https://static.redhat.com/test/rhel-networkmanager.txt once per second in every job registering the default monitor tests. The hostname resolves to both IPv4 and IPv6 addresses, but some CI build infrastructure has no IPv6 connectivity, so the probe failed intermittently and produced misleading ci-cluster-network-liveness disruption signal.

The generic endpoint is redundant: equivalent static endpoint monitoring already exists per cloud via the AWS, Azure, and GCP external cloud service monitors, which remain registered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 736b58cf-7e51-45c5-8b81-9466cd0e5df2

📥 Commits

Reviewing files that changed from the base of the PR and between b5dd46b and db63a95.

📒 Files selected for processing (2)
  • pkg/defaultmonitortests/types.go
  • pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go
💤 Files with no reviewable changes (2)
  • pkg/defaultmonitortests/types.go
  • pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The stable monitor registry no longer includes the generic external-service availability monitor. Its test framework implementation is deleted. The separate GCP, AWS, and Azure availability monitors remain registered.

Changes

Generic external-service monitor removal

Layer / File(s) Summary
Remove generic external-service monitor
pkg/defaultmonitortests/types.go, pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go
The registry import and registration for the generic external-service availability monitor are removed. Its constructors and test implementation are deleted. The GCP, AWS, and Azure availability monitor registrations remain.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to db63a

The generic probe is removed as intended, while cloud-specific availability monitoring remains in place. No actionable merge risk is identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removal of the static.redhat.com disruption monitor. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The PR adds no Ginkgo test titles or dynamic title construction. It removes the generic monitor registration and deletes its monitor implementation; the deleted titles were static literals. The …
Test Structure And Quality ✅ Passed PASS — The PR changes only the default monitor registry and deletes the external-service monitor implementation. It adds no Ginkgo It blocks, setup or cleanup code, cluster operations, waits, or ass…
Microshift Test Compatibility ✅ Passed PASS: The pull request only removes an external-service monitor import, registry entry, and implementation file. The authoritative diff contains no added Ginkgo e2e tests, so the MicroShift test-compa…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request adds no Ginkgo e2e tests. The authoritative diff only removes the generic external-service monitor registration and deletes its implementation; no new It, Describe, Context, or …
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only the monitor registry and deletes an external-service monitor implementation. The authoritative diff contains no deployment manifests, operator/controller code, replicas, …
Ote Binary Stdout Contract ✅ Passed The pull request only removes a monitor registration, its import, and the monitor implementation. The diff adds no code and introduces no process-level stdout writes. The deleted implementation contai…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request adds no Ginkgo e2e tests. It removes the generic external-service monitor and its registry entry, including the probe to static.redhat.com. The remaining changes do not introduce IPv4…
No-Weak-Crypto ✅ Passed PASS. The pull request only removes the generic external-service monitor, its import, and its registry entry. The diff adds no cryptographic code, weak algorithms, custom crypto, or secret comparisons…
Container-Privileges ✅ Passed The PR changes only pkg/defaultmonitortests/types.go and deletes a Go monitor implementation. The patch contains no container or Kubernetes manifest changes and no matches for privileged, `hostPID…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds no code or log statements. It only removes the generic monitor registration and deletes its implementation, including the static.redhat.com endpoint probe. No sensitive data is i…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from deads2k and sjenning September 29, 2026 16:34
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2026
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Sep 29, 2026
@dgoodwin

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2026
@openshift-ci

openshift-ci Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jogeo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6

@jogeo

jogeo commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@jogeo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn db63a95 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 db63a95 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants