Skip to content

fix: fall back to tmpdir state when CLAUDE_PLUGIN_DATA state is empty #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmchow wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: fall back to tmpdir state when CLAUDE_PLUGIN_DATA state is empty #125

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22d42f4
fix: fall back to tmpdir state when CLAUDE_PLUGIN_DATA state is empty
tmchow Apr 3, 2026
f59803f
refactor: migrate fallback state to persistent plugin data dir
tmchow Apr 3, 2026
e68aef3
fix: use cpSync for recursive state migration to avoid EISDIR
tmchow Apr 3, 2026
954bc67
fix: rewrite logFile paths in migrated state.json
tmchow Apr 3, 2026
8f6f1f9
fix: handle Windows escaped backslash paths in state migration
tmchow Apr 3, 2026
f8c83de
fix: rewrite paths in migrated job files, not just state.json
tmchow Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: rewrite logFile paths in migrated state.json 
After cpSync copies state from tmpdir to the persistent plugin data
dir, job.logFile paths inside state.json still reference the old
/tmp/... location. Replace all occurrences of the fallback dir path
with the new primary dir path in the migrated state file.
  • Loading branch information
@tmchow
tmchow committed Apr 3, 2026
commit 954bc67b7118ae7503552f2a6c3bc74b33b3a13b
12 changes: 12 additions & 0 deletions plugins/codex/scripts/lib/state.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,18 @@ export function resolveStateDir(cwd) {
// future reads/writes use the plugin data dir and state survives tmp cleanup.
if (!fs.existsSync(path.join(primaryDir, STATE_FILE_NAME)) && fs.existsSync(path.join(fallbackDir, STATE_FILE_NAME))) {
fs.cpSync(fallbackDir, primaryDir, { recursive: true });
Comment thread
tmchow marked this conversation as resolved.
// Rewrite logFile paths in migrated state.json so they point to the
// new persistent location instead of the old tmpdir.
const migratedStateFile = path.join(primaryDir, STATE_FILE_NAME);
try {
const raw = fs.readFileSync(migratedStateFile, "utf8");
const updated = raw.replaceAll(fallbackDir, primaryDir);
Comment thread
tmchow marked this conversation as resolved.
Outdated
if (updated !== raw) {
fs.writeFileSync(migratedStateFile, updated, "utf8");
}
} catch {
// Non-fatal: state still works, just with stale log paths
}
}
return primaryDir;
}
Expand Down