Repository navigation
Include tools changes in existing turn analytics - #50943
Closed
aibrahim-oai wants to merge 6 commits into
Closed
aibrahim-oai wants to merge 6 commits into
aibrahim-oai wants to merge 6 commits into
Conversation
jgershen-oai
self-requested a review
October 4, 2026 20:46
jgershen-oai
approved these changes
Oct 4, 2026
jif-oai
approved these changes
Oct 4, 2026
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn analytics currently cannot show how often the available tools change during a session. Include
tools_change_countoncodex_turn_event, next to the existing sampling and retry counts, so the backend can break it down using the event's usual originator/client tags.Compare the existing shared
Prompt.toolslist at the common inference entry point. Increment once whenever it differs from the previous inference call, including across turns, and report the count on the current turn. The first call, identical retries and compaction do not increment it. This counts all tool-definition differences, including fields that are not serialized for some models; it measures changes to tools and does not establish an actual cache miss.Validation:
just fmtandgit diff --checkpassed. The existing core turn-profile test covers baseline, unchanged retries, tool fields, additions, ordering, removal and continuity after a transport fallback. Analytics serialization was tested in the preceding PR revision.just test -p codex-core: 3,694 passed, 22 failed, 9 skipped. The tools-change regression passed; the 22 failures are exactly the same tests as the saved run before this revision (no new failures).