Repository navigation
Use server model defaults for connected TUI fresh starts - #50913
Merged
copyberry[bot] merged 1 commit intoOct 4, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Fresh starts connected to an app server can bootstrap with stale client model settings before reading the server configuration. An empty model catalog can also prevent startup even when managed new-thread defaults provide a model. ## What changed - Read server configuration before model bootstrap for fresh starts using a local daemon or remote server without an explicit profile. - Preserve explicit model and reasoning-effort overrides, clear implicit client settings when `config/read` is unsupported, and allow managed new-thread defaults to supply a model when the catalog is empty. - Use the launch directory for local daemon configuration reads and the server directory for remote reads. ## Testing Update startup-default tests to cover managed model selection with an empty catalog. Strengthen the reconnect test with a stale client model and an assertion that `config/read` uses the server directory. GitOrigin-RevId: 8fe1485c6e66c8d46560b34d904ce1724458993a
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8fe1485c6e66c8d46560b34d904ce1724458993a
branch
from
October 4, 2026 16:57
cf19e83 to
c2f7fe8
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8fe1485c6e66c8d46560b34d904ce1724458993a
branch
October 4, 2026 16:57
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use server model defaults for connected TUI fresh starts
Why
Fresh starts connected to an app server can bootstrap with stale client model settings before reading the server configuration. An empty model catalog can also prevent startup even when managed new-thread defaults provide a model.
What changed
config/readis unsupported, and allow managed new-thread defaults to supply a model when the catalog is empty.Testing
Update startup-default tests to cover managed model selection with an empty catalog. Strengthen the reconnect test with a stale client model and an assertion that
config/readuses the server directory.