Skip to content

Open slash commands from empty drafts in Vim Normal mode - #50788

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/806c2f6b841190ccdc1a258f88dfa590773ba33a
Oct 4, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/806c2f6b841190ccdc1a258f88dfa590773ba33a

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Open slash commands from empty drafts in Vim Normal mode

Why

Pressing / in Vim Normal mode starts a composer search, even when the draft is empty. Allow this key to open slash commands directly on an empty draft.

What changed

When slash commands are enabled, a standalone / on an empty draft switches to Insert mode, inserts /, and opens command completion. Preserve Vim search behavior for nonempty drafts, ?, and pending operators.

Testing

Add a snapshot test for the Insert mode transition and command picker. Exercise Vim slash-command entry in the transcript overlay test across terminal sizes, and extend command sparkle coverage to Vim mode.

## Why

Pressing `/` in Vim Normal mode starts a composer search, even when the draft is empty. Allow this key to open slash commands directly on an empty draft.

## What changed

When slash commands are enabled, a standalone `/` on an empty draft switches to Insert mode, inserts `/`, and opens command completion. Preserve Vim search behavior for nonempty drafts, `?`, and pending operators.

## Testing

Add a snapshot test for the Insert mode transition and command picker. Exercise Vim slash-command entry in the transcript overlay test across terminal sizes, and extend command sparkle coverage to Vim mode.

GitOrigin-RevId: 806c2f6b841190ccdc1a258f88dfa590773ba33a
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/806c2f6b841190ccdc1a258f88dfa590773ba33a branch from 9ccc696 to b8dceb0 Compare October 4, 2026 04:33
@copyberry
copyberry Bot merged commit b8dceb0 into main Oct 4, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/806c2f6b841190ccdc1a258f88dfa590773ba33a branch October 4, 2026 04:33
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 4, 2026
@jimparis
jimparis deployed to issue-triage October 4, 2026 04:59 — with GitHub Actions Active
@jimparis
jimparis deployed to issue-triage October 4, 2026 04:59 — with GitHub Actions Active
@jimparis
jimparis deployed to issue-triage October 4, 2026 04:59 — with GitHub Actions Active
@chmcg1
chmcg1 deployed to issue-triage October 4, 2026 05:00 — with GitHub Actions Active
@chmcg1
chmcg1 deployed to issue-triage October 4, 2026 05:00 — with GitHub Actions Active
@chmcg1
chmcg1 deployed to issue-triage October 4, 2026 05:00 — with GitHub Actions Active
@jimparis
jimparis deployed to issue-triage October 4, 2026 05:00 — with GitHub Actions Active
@chmcg1
chmcg1 deployed to issue-triage October 4, 2026 05:01 — with GitHub Actions Active
@nakagawakun
nakagawakun deployed to issue-triage October 4, 2026 05:05 — with GitHub Actions Active
@nakagawakun
nakagawakun deployed to issue-triage October 4, 2026 05:05 — with GitHub Actions Active
@nakagawakun
nakagawakun deployed to issue-triage October 4, 2026 05:05 — with GitHub Actions Active
@nakagawakun
nakagawakun deployed to issue-triage October 4, 2026 05:07 — with GitHub Actions Active
@consultpunit
consultpunit deployed to issue-triage October 4, 2026 05:18 — with GitHub Actions Active
@consultpunit
consultpunit deployed to issue-triage October 4, 2026 05:18 — with GitHub Actions Active
@consultpunit
consultpunit deployed to issue-triage October 4, 2026 05:18 — with GitHub Actions Active
@gro83j
gro83j deployed to issue-triage October 4, 2026 05:29 — with GitHub Actions Active
@gro83j
gro83j deployed to issue-triage October 4, 2026 05:29 — with GitHub Actions Active
@gro83j
gro83j deployed to issue-triage October 4, 2026 05:29 — with GitHub Actions Active
@Winston55555
Winston55555 deployed to issue-triage October 4, 2026 05:35 — with GitHub Actions Active
@Winston55555
Winston55555 deployed to issue-triage October 4, 2026 05:35 — with GitHub Actions Active
@Winston55555
Winston55555 deployed to issue-triage October 4, 2026 05:35 — with GitHub Actions Active
@Frade718
Frade718 deployed to issue-triage October 4, 2026 05:38 — with GitHub Actions Active
@Frade718
Frade718 deployed to issue-triage October 4, 2026 05:38 — with GitHub Actions Active
@Frade718
Frade718 deployed to issue-triage October 4, 2026 05:38 — with GitHub Actions Active
@msafi
msafi deployed to issue-triage October 4, 2026 06:18 — with GitHub Actions Active
@msafi
msafi deployed to issue-triage October 4, 2026 06:18 — with GitHub Actions Active
@msafi
msafi deployed to issue-triage October 4, 2026 06:18 — with GitHub Actions Active
@msafi
msafi deployed to issue-triage October 4, 2026 06:19 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — b8dceb0d Deployed Oct 4, 2026 by msafi via Identify potential duplicates (open issues fallback) #51605
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.