Repository navigation
fix: inconsistent usage of base URL and API key - #507
Merged
Merged
Conversation
tibo-openai
changed the title
Collaborator
|
Nice, thank you for the fix and cleanup, this is going in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent commit introduced the ability to use third-party model providers. (Really appreciate it!)
However, the usage is inconsistent: some pieces of code use the custom providers, whereas others still have the old behavior. Additionally,
OPENAI_BASE_URLis now being disregarded when it shouldn't be.This PR normalizes the usage to
getApiKeyandgetBaseUrl, and enables the use ofOPENAI_BASE_URLif present.