Skip to content

Add attachment owner lookup to the app-server - #50094

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/30f4a20e00243d0023246d465a9b95213b3adeb6
Oct 1, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/30f4a20e00243d0023246d465a9b95213b3adeb6

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Add attachment owner lookup to the app-server

Why

thread/attachment/list lists attachments for a known thread. Clients also need to find the threads associated with a given attachment identity.

What changed

Add thread/attachmentOwner/list to return owning thread IDs and archive status for an exact attachmentType and identityKey. Support cursor pagination and an optional archived filter, including both archived and non-archived threads by default.

Wire the request through the thread store and update documentation, protocol schemas, and generated TypeScript and Python types. The lookup is limited to the configured thread store and reports current membership, not an atomic resource-cleanup check.

Testing

Extend app-server integration tests to cover exact type-and-key matching, multiple owners, archive filtering, and invalid cursor rejection.

## Why

`thread/attachment/list` lists attachments for a known thread. Clients also need to find the threads associated with a given attachment identity.

## What changed

Add `thread/attachmentOwner/list` to return owning thread IDs and archive status for an exact `attachmentType` and `identityKey`. Support cursor pagination and an optional `archived` filter, including both archived and non-archived threads by default.

Wire the request through the thread store and update documentation, protocol schemas, and generated TypeScript and Python types. The lookup is limited to the configured thread store and reports current membership, not an atomic resource-cleanup check.

## Testing

Extend app-server integration tests to cover exact type-and-key matching, multiple owners, archive filtering, and invalid cursor rejection.

GitOrigin-RevId: 30f4a20e00243d0023246d465a9b95213b3adeb6
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/30f4a20e00243d0023246d465a9b95213b3adeb6 branch from 44bdf5e to 2635431 Compare October 1, 2026 20:47
@copyberry
copyberry Bot merged commit 2635431 into main Oct 1, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/30f4a20e00243d0023246d465a9b95213b3adeb6 branch October 1, 2026 20:47
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026
@spongemak
spongemak deployed to issue-triage October 1, 2026 20:49 — with GitHub Actions Active
@spongemak
spongemak deployed to issue-triage October 1, 2026 20:49 — with GitHub Actions Active
@spongemak
spongemak deployed to issue-triage October 1, 2026 20:49 — with GitHub Actions Active
@spongemak
spongemak deployed to issue-triage October 1, 2026 20:51 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:53 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:53 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:53 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:54 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:54 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:54 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:55 — with GitHub Actions Active
@coygeek
coygeek deployed to issue-triage October 1, 2026 20:55 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants