Repository navigation
Add paginated reverse lookup for thread attachments - #50083
Merged
copyberry[bot] merged 1 commit intoOct 1, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Add `StateRuntime::list_thread_attachment_threads` to find threads by exact `attachment_type` and `identity_key`, including threads without previews. Return thread IDs and archive state, with filters for all, archived, or non-archived threads. Order results by thread ID and bind pagination cursors to the attachment identity and archive filter. Add a database index on `(attachment_type, identity_key, thread_id)` to support the lookup. ## Testing Add coverage for exact identity matching, archive filters, pagination, rejection of cursors reused with different lookup parameters, and membership updates after attachment removal or thread deletion. GitOrigin-RevId: 21f32eb0cb1845a82d740d67b374080b6e12eb03
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/21f32eb0cb1845a82d740d67b374080b6e12eb03
branch
from
October 1, 2026 19:55
ddf82d0 to
26a49b3
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/21f32eb0cb1845a82d740d67b374080b6e12eb03
branch
October 1, 2026 19:55
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add paginated reverse lookup for thread attachments
What changed
Add
StateRuntime::list_thread_attachment_threadsto find threads by exactattachment_typeandidentity_key, including threads without previews. Return thread IDs and archive state, with filters for all, archived, or non-archived threads.Order results by thread ID and bind pagination cursors to the attachment identity and archive filter. Add a database index on
(attachment_type, identity_key, thread_id)to support the lookup.Testing
Add coverage for exact identity matching, archive filters, pagination, rejection of cursors reused with different lookup parameters, and membership updates after attachment removal or thread deletion.